Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verify): resolve tagging issues #231

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

nmcharlton
Copy link
Collaborator

Description

Simplified capture querying for Verification tool to address issues seen when updating existing tags (e.g., species) on already approved captures.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?

  • Verify tool attempts to cache captures and remove them one by one as they are approved. This assumes that captures will no longer be included in the filter and was designed for when the tool was only used to verify captures.
  • Even when captures should be removed from the list, the captureImages state is set in VerifyContext in a synchronous loop and subsequently referenced before it can be guaranteed to have been updated, causing unexpected behaviour.
  • The result is that re-tagged captures are not removed from the page when they should be.

What is the new behavior?

  • When batch approval is complete, the captures query is rerun to ensure the user sees the captures that match the filter.

Breaking change

Does this PR introduce a breaking change?
No

Other useful information

  • Removed all the unused, commented-out code
  • Moved captures query effect to the context where it belongs
  • Updated the options for number of captures per page following user feedback
Verify.Captures.-.Treetracker.Admin.by.Greenstand.-.Google.Chrome.2021-12-04.21-45-08.1.mp4

@nmcharlton nmcharlton requested a review from gwynndp December 4, 2021 22:35
@nmcharlton nmcharlton requested a review from a team as a code owner December 4, 2021 22:35
@nmcharlton nmcharlton merged commit c6d1baf into Greenstand:master Dec 13, 2021
@nmcharlton nmcharlton deleted the fix/bulk-approve-captures branch December 13, 2021 18:16
mitia-anah pushed a commit to mitia-anah/treetracker-admin-client that referenced this pull request Feb 1, 2022
Ny-Rianala pushed a commit to Ny-Rianala/treetracker-admin-client that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify: Captures do not update correctly following approval
2 participants